The best time to upgrade your units in Call of Dragons is when there is an event like the Strongest Lord or any other event that requires you to train units and has great rewards. Also, it is best to wait until you get to Tier 5 units unlocked. When you have tier 5 unlocked, all training buffs from technology will be unlocked.